ci: add rust_ci.yaml github workflow #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
force-pushed
the
samlaf/ci--add-rust-ci-github-workflow
branch
from
1a595ec to
e43b501
Compare
bxue-l2
reviewed
Dec 16, 2024
.github/workflows/rust_ci.yaml
Outdated
| matrix: | ||
| # TODO: add back cannon and asterisc once we are using them | ||
| # See https://github.com/Layr-Labs/kona/blob/main/.github/workflows/rust_ci.yaml | ||
| target: ["native"] |
There was a problem hiding this comment.
do we actually want to build? it takes super long
bxue-l2
approved these changes
Dec 16, 2024
crates/proof/src/hint.rs
Outdated
| @@ -131,7 +131,7 @@ impl From<HintType> for &str { | |||
| HintType::L2AccountProof => "l2-account-proof", | |||
| HintType::L2AccountStorageProof => "l2-account-storage-proof", | |||
| HintType::L2PayloadWitness => "l2-payload-witness", | |||
| HintType::AltDACommitment => "altda-commitment", | |||
| HintType::EigenDACommitment => "altda-commitment", | |||
There was a problem hiding this comment.
I don't see a problem that changes from altda-commitment, to eigenda-commitment. But we. can decide later
There was a problem hiding this comment.
Actually realized that I had forgotten to change the string: c4ef7c9
…ad of "altda-commitment"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied over from https://github.com/Layr-Labs/kona/blob/main/.github/workflows/rust_ci.yaml but removed the cannon and asterics stuff for now, we can readd once we've understood how that code works and how to integrate it into our crates.