Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDO_NOT_MERGE:Release plz test #325

Closed
wants to merge 3 commits into from
Closed

DDO_NOT_MERGE:Release plz test #325

wants to merge 3 commits into from

Conversation

supernovahs
Copy link
Collaborator

@supernovahs supernovahs commented Feb 7, 2025 •
edited
Loading

Ref #322

What Changed?

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@supernovahs
Copy link
Collaborator Author

@MegaRedHand looks like this works

@MegaRedHand
Copy link
Contributor

Great! It seems it's creating a tag per crate: https://github.com/Layr-Labs/eigensdk-rs/releases/tag/eigen-utils-v0.2.0. Do you know if it's possible to create only a single one per version? I think having multiple per version will only lead to confusion.

@supernovahs
Copy link
Collaborator Author

we can disallow creating tags for packages by making git_tag_enable false. Then we manually create the github release?

@MegaRedHand
Copy link
Contributor

We can try disabling that, but enabling it on the eigensdk package (like it's explained here)

@MegaRedHand MegaRedHand deleted the release-plz-test branch February 17, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supernovahs @MegaRedHand