feat(draft): preview slashOperator shares + underlying slashed
#1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
reviewed
Sep 3, 2025
| _isOperatorRedistributable(operator, registeredSets) || _isOperatorRedistributable(operator, allocatedSets); | ||
| } | ||
|
|
||
| /// @inheritdoc IAllocationManager |
There was a problem hiding this comment.
How much space do we have left?
There was a problem hiding this comment.
will sort this out as well
| uint256 wadToSlash | ||
| ) public view returns (uint256 shares) { | ||
| // Fetch operator's allocation details. | ||
| Allocation memory allocation = getAllocation(operator, operatorSet, strategy); |
There was a problem hiding this comment.
We should make an internal function that does this logic and is called by this function as well as slashOperator
There was a problem hiding this comment.
Agree, will sort that out once my fn is sound.
| uint64 maxMagnitude = getMaxMagnitude(operator, strategy); | ||
| uint64 slashedMagnitude = uint64(uint256(allocation.currentMagnitude).mulWadRoundUp(wadToSlash)); | ||
| uint64 newMaxMagnitude = maxMagnitude - slashedMagnitude; | ||
|
|
There was a problem hiding this comment.
Needs to also include shares that are being deallocated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications:
Describe the modifications you've done.
Result:
After your change, what will change.