test: improve Merkle coverage
#1603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
force-pushed
the
test/merkle
branch
from
f3e7330 to
ed3e6dd
Compare
0xClandestine
commented
Aug 11, 2025
src/test/unit/libraries/Merkle.t.sol
Outdated
Comment on lines
14
to
112
| function test_verifyInclusion_ValidProof() public { | ||
| assertValidProofs(); | ||
| } | ||
|
|
||
| function test_verifyInclusion_EmptyProofs() public { | ||
| proofs = new bytes[](proofs.length); | ||
| assertInvalidProofs(); | ||
| } |
There was a problem hiding this comment.
NOTE: Adding tests to MerkleBaseTest will automatically test both sha256 and keccak tree variants.
0xClandestine
force-pushed
the
test/merkle
branch
from
89a8343 to
e28b08a
Compare
0xClandestine
commented
Aug 21, 2025
Comment on lines
+83
to
+84
| # If enabled, allows internal expectRevert calls to be used in tests. | ||
| allow_internal_expect_revert = true |
There was a problem hiding this comment.
This allows us to test library reverts without needing a harness.
0xClandestine
force-pushed
the
test/merkle
branch
from
fdc800e to
ca784b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Recent audits identified a lack of direct testing on the
Merklelibrary, and we want to fix that.Modifications:
Murky(the most commonly used test implementation) for root and inclusion proofs.OZfor inclusion proofs.Result:
More confidence, more coverage.