Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont call strategy if we have no burnable shares #1106

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix: dont call strategy if we have no burnable shares #1106

merged 1 commit into from
Feb 14, 2025

Conversation

wadealexc
Copy link
Collaborator

Motivation:

Fixes an issue arbitrary external contracts could be called via StrategyManager.burnShares. (Certora L-04)

Modifications:

StrategyManager.burnShares does not do an external call if the burnable share amount is zero

Result:

Should no longer be possible to call untrusted code directly through burnShares

8sunyuan
8sunyuan approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@8sunyuan 8sunyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized this would prevent reverts from Strategies that have a revert on 0 amount transfers

@0xClandestine 0xClandestine changed the title feat: dont call strategy if we have no burnable shares fix: dont call strategy if we have no burnable shares Feb 14, 2025
@wadealexc wadealexc merged commit 319d232 into slashing-magnitudes-fixes Feb 14, 2025
11 checks passed
@wadealexc wadealexc deleted the feat/no-empty-burn branch February 14, 2025 20:43
@wadealexc wadealexc mentioned this pull request Feb 18, 2025
Merged
ypatil12 pushed a commit that referenced this pull request Feb 19, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
373ba4b 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
1281a15 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
354afd5 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
fbe3d79 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
3ee8071 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
fe497b9 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
4794be6 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
4b82e2d 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
82280f0 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
cbbf9cf 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
37d52ec 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
fe4b0cc 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
70121af 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@wadealexc @ypatil12
fix: dont call strategy if we have no burnable shares (#1106)
aac6227 
**Motivation:**

Fixes an issue arbitrary external contracts could be called via
`StrategyManager.burnShares`. (Certora L-04)

**Modifications:**

`StrategyManager.burnShares` does not do an external call if the
burnable share amount is zero

**Result:**

Should no longer be possible to call untrusted code directly through
`burnShares`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8sunyuan 8sunyuan 8sunyuan approved these changes

@ypatil12 ypatil12 ypatil12 approved these changes

Assignees
No one assigned
Labels
slashing audit fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wadealexc @8sunyuan @ypatil12 @0xClandestine