Skip to content

Commit

Permalink
chore: bring slashing-magnitudes-fixes up to date (#1135)
Browse files Browse the repository at this point in the history
**Motivation:**

Bring `slashing-magnitudes-fixes` up to date

**Modifications:**

Merge `dev` into `slashing-magnitudes-fixes`

Primary changes are:

- CI Improvements
- Typos
- Rewards V2.1 Updates
- Registrar Interface Update:
#1102

**Result:**

Ready for merge into dev

---------

Co-authored-by: Rajath Alex <[email protected]>
Co-authored-by: Michael Sun <[email protected]>
Co-authored-by: clandestine.eth <[email protected]>
Co-authored-by: Jay <[email protected]>
Co-authored-by: Gautham Anant <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Nadir Akhtar <[email protected]>
Co-authored-by: davidironblocks <[email protected]>
Co-authored-by: wadealexc <[email protected]>
Co-authored-by: Nadir Akhtar <[email protected]>
Co-authored-by: Nader Dabit <[email protected]>
Co-authored-by: Bowen Li <[email protected]>
  • Loading branch information
13 people committed Feb 20, 2025
1 parent 2f8621f commit 4542f58
Show file tree
Hide file tree
Showing 129 changed files with 4,462 additions and 2,499 deletions.
27 changes: 21 additions & 6 deletions .solhint.json → .github/configs/solhint.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,26 @@
"rules": {
"max-line-length": "off",
"no-inline-assembly": "off",
"reason-string": ["warn",{"maxLength":160}],
"func-visibility": ["warn",{"ignoreConstructors":true}],
"explicit-types": ["warn","explicit"],
"quotes": ["warn","double"],
"reason-string": [
"warn",
{
"maxLength": 160
}
],
"func-visibility": [
"warn",
{
"ignoreConstructors": true
}
],
"explicit-types": [
"warn",
"explicit"
],
"quotes": [
"warn",
"double"
],
"const-name-snakecase": "off",
"not-rely-on-time": "off",
"avoid-low-level-calls": "off",
Expand All @@ -18,6 +34,5 @@
"no-global-import": "off",
"immutable-vars-naming": "off",
"no-console": "off"

}
}
}
44 changes: 44 additions & 0 deletions .github/configs/storage-diff.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
{
"contracts": [
{
"name": "AVSDirectory",
"address": "0x135dda560e946695d6f155dacafc6f1f25c1f5af"
},
{
"name": "DelegationManager",
"address": "0x39053D51B77DC0d36036Fc1fCc8Cb819df8Ef37A"
},
{
"name": "RewardsCoordinator",
"address": "0x7750d328b314EfFa365A0402CcfD489B80B0adda"
},
{
"name": "StrategyManager",
"address": "0x858646372CC42E1A627fcE94aa7A7033e7CF075A"
},
{
"name": "StrategyFactory",
"address": "0x5e4C39Ad7A3E881585e383dB9827EB4811f6F647"
},
{
"name": "EigenPodManager",
"address": "0x91E677b07F7AF907ec9a428aafA9fc14a0d3A338"
},
{
"name": "EigenPod",
"address": "0xd4018Ce9A041a9c110A9d0383d2b5E1c66Ae1513"
},
{
"name": "stETH Strategy",
"address": "0x93c4b944D05dfe6df7645A86cd2206016c51564D"
},
{
"name": "EigenStrategy",
"address": "0xaCB55C530Acdb2849e6d4f36992Cd8c9D50ED8F7"
},
{
"name": "StrategyBase",
"address": "0x6c6E8aF98a49bBaBCc17ca1dbA6b95c5D58A2ccb"
}
]
}
68 changes: 68 additions & 0 deletions .github/configs/typos-cli.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
[files]
extend-exclude = [
"**/lib/**",
"**/docs/images/**",
# Not present locally, but is in remote (github).
"**/doc/**"
]
ignore-hidden = true
ignore-files = true
ignore-dot = true
ignore-vcs = true
ignore-global = true
ignore-parent = true

[default]
binary = false
check-filename = true
check-file = true
unicode = true
ignore-hex = true
identifier-leading-digits = false
locale = "en"
extend-ignore-identifiers-re = []
extend-ignore-words-re = []
extend-ignore-re = []

[default.extend-identifiers]

# Weird syntax, but this how you ignore corrections for certain words.
[default.extend-words]
strat = "strat"
froms = "froms"

[type.go]
extend-glob = []
extend-ignore-identifiers-re = []
extend-ignore-words-re = []
extend-ignore-re = []

[type.go.extend-identifiers]
flate = "flate"

[type.go.extend-words]

[type.sh]
extend-glob = []
extend-ignore-identifiers-re = []
extend-ignore-words-re = []
extend-ignore-re = []

[type.sh.extend-identifiers]
ot = "ot"
stap = "stap"

[type.sh.extend-words]

[type.py]
extend-glob = []
extend-ignore-identifiers-re = []
extend-ignore-words-re = []
extend-ignore-re = []

[type.py.extend-identifiers]
NDArray = "NDArray"
arange = "arange"
EOFError = "EOFError"

[type.py.extend-words]
11 changes: 11 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
**Motivation:**

*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*

**Modifications:**

*Describe the modifications you've done.*

**Result:**

*After your change, what will change.*
64 changes: 0 additions & 64 deletions .github/workflows/certora-prover.yml

This file was deleted.

62 changes: 62 additions & 0 deletions .github/workflows/certora.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
# name: Certora

# on:
# workflow_dispatch:
# pull_request:
# branches:
# - dev
# push:
# branches:
# - dev
# - master
# - release-v*
# - formal-verification
# - m2-mainnet
# - testnet-holesky

# jobs:
# certora:
# name: Test

# runs-on: ubuntu-latest
# steps:

# - uses: actions/checkout@v3
# with:
# submodules: recursive

# - name: Install Foundry
# uses: foundry-rs/foundry-toolchain@v1
# with:
# version: stable

# - name: Install forge dependencies
# run: forge install

# - name: Install Python
# uses: actions/setup-python@v2
# with:
# python-version: '3.10'
# cache: 'pip'

# - name: Install Java
# uses: actions/setup-java@v2
# with:
# distribution: temurin
# java-version: '17'

# - name: Install Certora CLI
# run: pip install certora-cli

# - name: Install Solidity Compiler
# run: |
# pip install solc-select
# solc-select use 0.8.27 --always-install

# - name: Run Certora Verification
# run: |
# for script in $(ls certora/scripts/{,**}/*.sh | grep -v '\WnoCI\W'); do
# bash "$script"
# done
# env:
# CERTORAKEY: ${{ secrets.CERTORAKEY }}
17 changes: 0 additions & 17 deletions .github/workflows/check-compilation.yml

This file was deleted.

43 changes: 43 additions & 0 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Check

on:
push:
workflow_dispatch: {}

permissions:
contents: read
pull-requests: read

env:
CLICOLOR: 1

jobs:
typos:
name: Typo Linting
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: crate-ci/[email protected]
with:
config: .github/configs/typos-cli.toml

commitlint:
name: Commit Linting
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: wagoid/commitlint-github-action@v6

go-bindings:
name: Bindings
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Build and validate
if: github.event_name == 'push'
run: |
make docker
docker run -v `pwd`:/build -w /build --rm -i eigenlayer-contracts:latest bash -c "make gha"
if [ ! -z "$(git status --porcelain)" ]; then git diff; git status; exit 1; fi
23 changes: 0 additions & 23 deletions .github/workflows/commitlint.yml

This file was deleted.

Loading

0 comments on commit 4542f58

Please sign in to comment.