Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance traffic generator error handling and logging #1224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DeVikingMark
Copy link

Why are these changes needed?

The traffic generator has several critical issues with error handling and resource management:

  • Goroutine errors are silently ignored
  • No proper error propagation from worker instances
  • Resource leaks in ticker usage
  • Insufficient logging for debugging production issues
  • Lack of proper shutdown handling

These changes implement proper error handling, improve logging, and fix resource management issues.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant