Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve srs ingestion bug, cfg verification, & return error messages in response body #64

Merged
merged 7 commits into from
Jul 21, 2024

Conversation

ethenotethan
Copy link
Collaborator

fix: resolve srs ingestion bug, cfg verification, & return error messages in response body

Changes proposed

  • Fix SRS ingestion bug which was causing blobs greater than 1.2 mb to fail to verify. This required retuning the kzg loader to intake the entire G1 SRS with the number of points read being proportional the max blob size (i.e,max_blob_bytes / 32) to specify the max number of field elements.
  • Update config verification with more verbose invariants and unit tests.
  • Added test that tests known failure case in existing EigenDA batcher where identical merkle inclusion proof are generated for blobs in the same batch with identical contents.
  • removed use of assert in favor of require for more standardized testing.
  • added test to assert that a blob of 2MB can be successfully dispersed and verified.

Screenshots (Optional)

Note to reviewers

@teddyknox teddyknox force-pushed the epociask--fix-srs-ingestion-config-processing-bugs branch 2 times, most recently from 7751ebe to d148eb6 Compare July 21, 2024 04:31
@teddyknox teddyknox force-pushed the epociask--fix-srs-ingestion-config-processing-bugs branch from d148eb6 to 061e0a5 Compare July 21, 2024 04:35
@teddyknox teddyknox merged commit 98c0585 into main Jul 21, 2024
7 checks passed
@ethenotethan ethenotethan deleted the epociask--fix-srs-ingestion-config-processing-bugs branch August 22, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants