feat: add memstore config to return failover errors on puts #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for testing failover in batcher. Right now a new proxy would need to be spun up with this config turned on. We should consider adding an admin rpc rpi to turn these on/off dynamically.
samlaf
changed the title
ethenotethan
previously approved these changes
Feb 13, 2025
store/generated_key/memstore/cli.go
Outdated
| @@ -67,18 +76,25 @@ func CLIFlags(envPrefix, category string) []cli.Flag { | |||
| }, | |||
| &cli.DurationFlag{ | |||
| Name: PutLatencyFlagName, | |||
| Usage: "Artificial latency added for memstore backend to mimic EigenDA's dispersal latency.", | |||
| Usage: "(FOR TESTING) Artificial latency added for memstore backend to mimic EigenDA's dispersal latency.", | |||
There was a problem hiding this comment.
nit - isn't this entire construction used for testing? maybe less redundant to put disclosure in category description instead
There was a problem hiding this comment.
Good point haha, removed
55b4ec1
samlaf
deleted the
chore--add-memstore-config-to-return-failover-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for testing failover in batcher.
Right now a new proxy would need to be spun up with this config turned on. We should consider adding an admin rpc rpi to turn these on/off dynamically.
Fixes Issue
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers