ci: add test to make sure env vars in .env.example.holesky are valid #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxue-l2
previously approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes #
Changes proposed
Mantle has run into issues because one of the flags in our .env.holesky.example file was incorrect.
This PR removes the flags in the README which are just very prone to be outdated and induce errors like this, and also adds a ci check to make sure the flags defined in .env.example.holesky are valid. This test is simple and will only catch if that file still contains deprecated flags (which cause the proxy to crash on startup); it won't be able to catch the subtle case above where the flag is not an old deprecated flag but instead just an unused env var.
Screenshots (Optional)
Note to reviewers