fix: request record label with commitment mode and version #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
force-pushed
the
hope/commitment-mode-metrix
branch
3 times, most recently
from
cbf7243 to
9b8680f
Compare
hopeyen
force-pushed
the
hope/commitment-mode-metrix
branch
from
20a0f6d to
d244f3e
Compare
ethenotethan
reviewed
Sep 4, 2024
ethenotethan
approved these changes
Sep 5, 2024
hopeyen
force-pushed
the
hope/commitment-mode-metrix
branch
from
1b60e4f to
b5e3a07
Compare
bxue-l2
reviewed
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
http_server_request_totalandhttp_server_request_duration(HTTP server request counts and durations) to includecommitment_modeandcommitment_versionhttp_server_requests_bad_headermetrics withmethod, error_typelabel for requests that can't be parsed withcommitment_modeandcommitment_version.Note to reviewers
I can combine the new metrics to
RecordRPCServerRequestand record commitment mode and version (or errors of reading them) after handling the request if preferred