-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support explict modes for read fallbacks and caching #104
Merged
ethenotethan
merged 8 commits into
main
from
epociask--feat-explicit-caching-and-fallbacks
Aug 29, 2024
Merged
feat: Support explict modes for read fallbacks and caching #104
ethenotethan
merged 8 commits into
main
from
epociask--feat-explicit-caching-and-fallbacks
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fg validation tests
hopeyen
reviewed
Aug 26, 2024
samlaf
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. added some small nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes NA
Changes proposed
TLDR Modularized storage backend providers to allow for easy addition in the future. Additionally added explicit support for optional read fallback and caching that allows a user to construct custom configurations of proxy based on their individual risk tolerance / requirement for decentralization. E.g, I'm a customer and want caching with redis and read fallback with S3 - I can now do that (excluding redis cuz we haven't implemented yet).
Verbose Summary
Screenshots (Optional)
Note to reviewers
We can probably create a definition object for each storage backend to describe its allowed modes but this likely isn't necessary unless we envision support for 10+ backends with additional secondary modes outside of
read-fallback, cache
. We could also support many instance configurations (e.g, a separate S3 bucket for caching vs. fallback) if this is something that customers want down the line. All sensitive flows should be tested, but please review diligently.NOTE: This PR also allows us to scale memstore in the future as well. E.g, if we have redis we can configure it as a read-fallback target when doing node development to ensure we can still reference old memory state after rebooting the proxy instance.