Skip to content

Commit

Permalink
chore: bump default confirmationDepth 5->8
Browse files Browse the repository at this point in the history
  • Loading branch information
samlaf committed Feb 11, 2025
1 parent 36d49a3 commit 1fc69e3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,9 @@ To target this feature, use the CLI flags `--eigenda-svc-manager-addr`, `--eigen
An optional `--eigenda.confirmation-depth` flag can be provided to specify a number of ETH block confirmations to wait for the confirmBatch to have landed onchain before returning the cert to the batcher after having dispersed a blob in the put route. The flag value can either be the string 'finalized' or a number:
`finalized`: Wait for the confirmBatch transaction to be finalized on-chain before returning the cert to the batcher
`0`: Verify the cert immediately upon blob confirmation and return the cert
`N where 0<N<64`: Wait `N` blocks before returning the cert to the batcher (default value is 5)
`N where 0<N<64`: Wait `N` blocks before returning the cert to the batcher

The default value is 5. Using 0 is dangerous: see [troubleshooting the batch-hash-mismatch error](./docs/troubleshooting_v1.md#batch-hash-mismatch-error).
The default value is 8. Using 0 is dangerous: see [troubleshooting the batch-hash-mismatch error](./docs/troubleshooting_v1.md#batch-hash-mismatch-error).

### In-Memory Backend

Expand Down
2 changes: 1 addition & 1 deletion flags/eigendaflags/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func CLIFlags(envPrefix, category string) []cli.Flag {
Usage: "Number of Ethereum blocks to wait after the blob's batch has been included on-chain, " +
"before returning from PutBlob calls. Can either be a number or 'finalized'.",
EnvVars: []string{withEnvPrefix(envPrefix, "CONFIRMATION_DEPTH")},
Value: "5",
Value: "8",
Category: category,
Action: func(_ *cli.Context, val string) error {
return validateConfirmationFlag(val)
Expand Down

0 comments on commit 1fc69e3

Please sign in to comment.