hlp/sdk-finalize-and-quote-asset-update #1874

shankars99 · 2025-12-11T02:42:39Z

SDK Updates

Quote Assets

USDe is now a known quote asset on mainnet.

Hyperliquid's quote asset protocol automatically deploys a HYPE/ASSET spot market pair when an asset is promoted to a quote asset. Based on this we can assert that the ASSET of every HYPE/ASSET spot pair is a quote asset.

New command added to check if a given core spot is a quote asset.

This logic is applied to registerSpot (part of core spot deploy) and composer deployments to ensure that users deploy FeeToken or regular composers.

EVM<>Core Linking

Renamed files from register* to link* to match hyperliquid's documentation.

Also created a new command to generate a CoreWriter compatible finalizeEvmContract payload that needs to be signed and submitted to CoreWriter (0x3333333333333333333333333333333333333333)

refer: https://hyperliquid.gitbook.io/hyperliquid-docs/for-developers/hyperevm/interacting-with-hypercore#corewriter-contract

Docs update

For quote asset and new commands

Signed-off-by: shankar [email protected]

Signed-off-by: shankar <[email protected]>

…if an asset is quote asset Signed-off-by: shankar <[email protected]>

Signed-off-by: shankar <[email protected]>

github-actions · 2025-12-16T01:13:29Z

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

Network connectivity issues
RPC rate limiting
External service downtime
Action Run: https://github.com/LayerZero-Labs/devtools/actions/runs/20252984104

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

tinom9

🔝

examples/oft-hyperliquid/HYPERLIQUID.README.md

packages/hyperliquid-composer/src/commands/core-spot-deployment.ts

tinom9 · 2025-12-16T01:51:40Z

packages/hyperliquid-composer/src/commands/list-quote-asset.ts

+    } catch (error) {
+        logger.error(`Failed to check quote asset status: ${error}`)
+        process.exit(1)
+    }


I understand we want to be try-catching to avoid ugly errors from node.

Can we do it once at the CLI entrypoint?

imo cli should at-most validate inputs and is a wrapper to commands

I would prefer consistency on how we handle process terminations on errors for cases like this at the CLI level, as we're don't know what exactly went wrong.

Still a nit though, can be disregarded.

packages/hyperliquid-composer/src/operations/spotMeta.ts

packages/hyperliquid-composer/HYPERLIQUID.README.md

packages/hyperliquid-composer/README.md

packages/hyperliquid-composer/src/cli.ts

Signed-off-by: shankar <[email protected]>

github-actions · 2025-12-16T03:19:09Z

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

Network connectivity issues
RPC rate limiting
External service downtime
Action Run: https://github.com/LayerZero-Labs/devtools/actions/runs/20255243413

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

Signed-off-by: shankar <[email protected]>

github-actions · 2025-12-16T03:39:54Z

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

Network connectivity issues
RPC rate limiting
External service downtime
Action Run: https://github.com/LayerZero-Labs/devtools/actions/runs/20255597324

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

Signed-off-by: shankar <[email protected]>

github-actions · 2025-12-16T03:48:44Z

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

Network connectivity issues
RPC rate limiting
External service downtime
Action Run: https://github.com/LayerZero-Labs/devtools/actions/runs/20255763745

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

ravinagill15

Looks good, minor nits, no need to update in this PR

ravinagill15 · 2025-12-16T23:31:23Z

packages/hyperliquid-composer/src/commands/link-evm-core.ts

+const COREWRITER_ADDRESS = '0x3333333333333333333333333333333333333333'
+const FINALIZE_EVM_CONTRACT_ACTION_TYPE_PREFIX = '0x01000008'
+const ACTION_TYPE_FINALIZE = 1


nit: can move this to a constants.ts file

ravinagill15 · 2025-12-16T23:32:51Z

packages/hyperliquid-composer/src/operations/spotMeta.ts

+    const hypeTokenIndex = isTestnet ? HYPE_INDEX.TESTNET : HYPE_INDEX.MAINNET
+
+    // Get all HYPE trading pairs with metadata
+    const { pairs, tokens } = await getSpotPairsWithMetadata(isTestnet, hypeTokenIndex, logLevel)


potentially wrap with try/catch for in case of API failures

github-actions · 2025-12-17T00:18:59Z

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

Network connectivity issues
RPC rate limiting
External service downtime
Action Run: https://github.com/LayerZero-Labs/devtools/actions/runs/20287018246

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

shankars99 requested a review from lzErfan December 11, 2025 04:43

shankars99 force-pushed the hlp/sdk-finalize-and-quote-asset-update branch from e7ea8ff to 7ecbe53 Compare December 12, 2025 00:39

shankars99 requested review from ravinagill15 and tinom9 December 15, 2025 23:40

shankars99 added 14 commits December 16, 2025 00:43

feat: new command to finalize using CoreWriter + rename

77f1d72

Signed-off-by: shankar <[email protected]>

docs: usage of finalizeEvmContract via CoreWriter

4c21c86

Signed-off-by: shankar <[email protected]>

feat: quote asset helper function to list all quote assets and check …

e2a9adf

…if an asset is quote asset Signed-off-by: shankar <[email protected]>

chore: adding index.ts

60357d1

Signed-off-by: shankar <[email protected]>

chore: registerSpot uses new quote asset checker for custom quote assets

2c38846

Signed-off-by: shankar <[email protected]>

docs: new quote asset command

2d08b3b

Signed-off-by: shankar <[email protected]>

chore: add USDe as known quote asset

10e4b96

Signed-off-by: shankar <[email protected]>

chore: improved error handling on parsing

474be2d

Signed-off-by: shankar <[email protected]>

chore: update examples to use quote asset checker

7710a35

Signed-off-by: shankar <[email protected]>

docs: quote asset documentation

ca53638

Signed-off-by: shankar <[email protected]>

pnpm lint:fix

2a2b0f6

Signed-off-by: shankar <[email protected]>

pnpm changeset

9903f27

Signed-off-by: shankar <[email protected]>

docs: add FeeAbstraction Composer

32dddf5

Signed-off-by: shankar <[email protected]>

chore: improved error handling when token is not deployed

f187628

Signed-off-by: shankar <[email protected]>

shankars99 added the ready to review in a state where CI passes and the PR is quite upto date with main and you need reviews label Dec 16, 2025

shankars99 force-pushed the hlp/sdk-finalize-and-quote-asset-update branch from 31a2e84 to f187628 Compare December 16, 2025 01:08

LayerZero-Labs deleted a comment from github-actions bot Dec 16, 2025

tinom9 reviewed Dec 16, 2025

View reviewed changes

shankars99 added 4 commits December 16, 2025 03:12

docs: package README to only display sdk commands

83a6931

Signed-off-by: shankar <[email protected]>

error-log: update error log to account for http errors

1ed241a

Signed-off-by: shankar <[email protected]>

docs: categorize Finalize methods - sdk and corewriter

0e0435f

Signed-off-by: shankar <[email protected]>

chore: fix path references

fc0f3d0

Signed-off-by: shankar <[email protected]>

rename to list-quote-assets

c35fa22

Signed-off-by: shankar <[email protected]>

chore: remove unnecessary typecasting

b2569a0

Signed-off-by: shankar <[email protected]>

tinom9 approved these changes Dec 16, 2025

View reviewed changes

ravinagill15 approved these changes Dec 16, 2025

View reviewed changes

Merge branch 'main' into hlp/sdk-finalize-and-quote-asset-update

e8c22de

shankars99 enabled auto-merge December 17, 2025 00:13

shankars99 added this pull request to the merge queue Dec 17, 2025

Merged via the queue into main with commit bb2f4c3 Dec 17, 2025
17 checks passed

shankars99 deleted the hlp/sdk-finalize-and-quote-asset-update branch December 17, 2025 00:52

hlp/sdk-finalize-and-quote-asset-update #1874

hlp/sdk-finalize-and-quote-asset-update #1874

Uh oh!

Conversation

shankars99 commented Dec 11, 2025

Quote Assets

EVM<>Core Linking

Docs update

Uh oh!

github-actions bot commented Dec 16, 2025

🚨 E2E Tests Failed

Uh oh!

tinom9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tinom9 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

shankars99 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

tinom9 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 16, 2025

🚨 E2E Tests Failed

Uh oh!

github-actions bot commented Dec 16, 2025

🚨 E2E Tests Failed

Uh oh!

github-actions bot commented Dec 16, 2025

🚨 E2E Tests Failed

Uh oh!

ravinagill15 left a comment

Choose a reason for hiding this comment

Uh oh!

ravinagill15 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

ravinagill15 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 17, 2025

🚨 E2E Tests Failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants