feat: multi-version compatible adapter 1.26.3-1.26.13 and stability fix#43
Closed
wlkek wants to merge 2 commits into
Closed
feat: multi-version compatible adapter 1.26.3-1.26.13 and stability fix#43wlkek wants to merge 2 commits into
wlkek wants to merge 2 commits into
Conversation
wlkek
commented
May 5, 2026
- Extended version mapping support 1.26.3 to 1.26.13
- Client version updated to v2.6.3
- Use Python embed_resource.py instead of ld.exe to embed resources
- Added a null pointer protection to prevent crashes:
- Hook::hook() adds a target==0 check
- Keyboard::isKeyDown() adds a check for keyMap null
- All functions of the tessellator added empty check for signature
- MinecraftPackets::createPacket() adds an empty check
- ItemStackBase::getHoverName() fixed and added null check
- Item::getDamageValue() Add an empty check
- Actor adds empty checks for all component functions
- Player::getMoveInputComponent() adds an empty check
- ClientInstance::grabCursor/releaseCursor/get() adds an empty check
- GameCore::get() adds a null check
- GeneralHooks adds a null check for MouseInputVector
- Accelerated by downloading using a mirror
- mnemosyne disabled test build
- 扩展版本映射支持 1.26.3 至 1.26.13 - 客户端版本更新至 v2.6.3 - 使用 Python embed_resource.py 替代 ld.exe 嵌入资源 - 添加空指针保护防止崩溃: - Hook::hook() 添加 target==0 检查 - Keyboard::isKeyDown() 添加 keyMap 空检查 - Tessellator 所有函数添加签名空检查 - MinecraftPackets::createPacket() 添加空检查 - ItemStackBase::getHoverName() 修复并添加空检查 - Item::getDamageValue() 添加空检查 - Actor 所有组件函数添加空检查 - Player::getMoveInputComponent() 添加空检查 - ClientInstance::grabCursor/releaseCursor/get() 添加空检查 - GameCore::get() 添加空检查 - GeneralHooks 添加 MouseInputVector 空检查 - 依赖下载使用镜像加速 - mnemosyne 禁用测试构建
Member
|
Don't add 10+ random changes to a PR, if you must do all of these at least split them up. There's a lot of questionable changes here (using a random mirror just for cpm seems odd, why would we use a python script for embedding resources over ld, which is widely used and understood, etc.), was this vibecoded? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.