Skip to content

add simple token auth for api (random string) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Freeongoo
Copy link
Contributor

Because it's a bad idea to leave api open for everyone, so that everyone can edit the list of companies :)

@ModestasV
Copy link

@Freeongoo Wouldn't passport be better here? I mean, your implementation is allright but installing passport - would do most of the stuff you are doing.

See links:
https://laravel.com/docs/5.6/passport
https://laravel.com/docs/5.6/passport#consuming-your-api-with-javascript

@Freeongoo
Copy link
Contributor Author

@ModestasV, yes i know, but this is simple project and simple auth, IMHO

@PovilasKorop
Copy link
Collaborator

@Freeongoo actually Laravel Passport is really simple. I intentionally left this outside, cause people can implement Auth thing however they want, with Passport or JWT or whatever. This is outside of the scope of this project.

@Freeongoo
Copy link
Contributor Author

@PovilasKorop ok

@ModestasV
Copy link

@Freeongoo Just don't feel discouraged - we do see the good in what you did and honestly, I would leave this pull request for people to see the possible implementation! It is a nice job on showing how this could be done in few simple steps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants