Fix required field asterisk on array of rules for field

[jnoordsij]

WHY

BEFORE - What was wrong? What was happening before this PR?

When using the crud->setValidation helper with a request class or ruleset, where properties have an array of rules applied to them, the field would only be marked as 'required' if the first element of the ruleset would be required, rather than any of them.

This is caused by the 'outer' loop variable $key being overwritten inside the loop, causing it to be false after the first (mismatched) iteration.

AFTER - What is happening after this PR?

The field is correctly marked as required if there is any required rule in its rule array.

HOW

How did you achieve that, in technical terms?

By using a separate variable name for listing the field, we ensure $key will always be the original fieldname.
I also immediately break the loop if a field is found to be required for a slight performance benefit.

Finally I've also updated all the related tests slightly to ensure they contain a non-required field,
to ensure tests also check for false positives.

Is it a breaking change?

No

How can we test the before & after?

See added test: when running the first commit (new test + no fix) tests fail; then the test is fixed by the commit after

[jcastroa87]

Hello @jnoordsij thanks for the PR, i will ask @pxpm to check it, if everything is ok, will be merged soon.

Cheers.