Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Javadoc documentation to project #18

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Conversation

subhramit
Copy link
Contributor

@subhramit subhramit commented Nov 11, 2024

Closes #8

Adds javadoc documentation to all classes and methods in the project (except for obvious methods such as setters in LambdaTestTask).

I have kept the documentation thorough, including how one class is dependent on another. Please read through and let me know if any additions/removals are necessary.

@subhramit
Copy link
Contributor Author

subhramit commented Nov 11, 2024

I'm getting code format CI errors. I'm not sure why...
Update: Nvm fixed

@navin772
Copy link
Member

@subhramit can you take a look at the output of ./gradlew javadoc, it shows some errors which needs to be fixed.
One of the errors were - error: unknown tag: implNote, and other missing doc warnings.

Can you please fix those?

@subhramit
Copy link
Contributor Author

subhramit commented Nov 11, 2024

@subhramit can you take a look at the output of ./gradlew javadoc, it shows some errors which needs to be fixed.
One of the errors were - error: unknown tag: implNote, and other missing doc warnings.

Can you please fix those?

@implNote (implementation note) is a common javadoc tag. I'll double check.

Findings: as per https://bugs.openjdk.org/browse/JDK-8068562, they are recognized but not considered standard (didn't know this!). I'll change them.

@subhramit
Copy link
Contributor Author

subhramit commented Nov 11, 2024

Although @implNote expands properly in IntelliJ (if we are targeting developers to be able to navigate through the javadoc when contributing), I am changing @implnote tag to "Implementation note:" text to fix the errors.

Old (as tag):
image

New (as text):
image

@subhramit subhramit requested a review from Delta456 November 13, 2024 15:43
@subhramit
Copy link
Contributor Author

subhramit commented Nov 18, 2024

@navin772 let me know if anything else is needed! All errors are fixed.

@navin772
Copy link
Member

@subhramit is there any way we can have the @implNote so it renders as tag and we can ignore the @implNote specific errors. Or any other tag that can be used here?

@subhramit
Copy link
Contributor Author

@subhramit is there any way we can have the @implNote so it renders as tag and we can ignore the @implNote specific errors. Or any other tag that can be used here?

Good point. Will do some reading on this and get back.

@subhramit
Copy link
Contributor Author

@navin772 Explored a couple of options. This (dcd1533) seems to be the best fit.

Copy link
Member

@navin772 navin772 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@navin772 navin772 merged commit cbffe05 into LambdaTest:main Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JavaDoc Comments to All Classes
3 participants