Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added splash screen #18

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Added splash screen #18

merged 1 commit into from
Feb 12, 2022

Conversation

samitkapoor
Copy link
Contributor

@samitkapoor samitkapoor commented Feb 11, 2022

Related Issue

Proposed Changes

  • Made splash screen for the application using the dark theme.
  • I removed an unused dependency in the pubspec.yaml file i.e. assets/icons/ otherwise it was showing an error in the console.

Additional Info

  • The UI code for the splash screen can be found in lib/src/screens/welcome/welcome.dart and I also made separate widgets for the page, so it is easier to read. The widget related code can be found in lib/components/welcome_splash.dart and I had to create a model for each splash page that can be found in lib/model/welcome_model.dart.
  • Added a new route i.e. to splash screen in lib/routes/navigation_route.dart.

Checklist

  • [x ] ✅ My code follows the code style of this project.
  • 📝 My change requires a change to the documentation.
  • 🎀 I have updated the documentation accordingly.
  • [ x] 👀 I have read the CONTRIBUTING document.
  • ✨ I have added tests to cover my changes.
  • 🚩 All new and existing tests passed.
  • 🌟 ed the repo

I made splash screen for your application. All the code can be found in welcome.dart. I divided my code into separate files so that it is easier for reading purpose. I have followed all proper naming conventions. The separate widgets that I made for the application can be found in welcome_splash.dart. Since all the screens had same theme, a photo, a heading, a caption, and an index. So I created a separate model class for it welcome_model.dart. I created a new controller WelcomeController for the navigating between the pages and to store the content of the page and also for the pagination below the images. The skip button on the splash screen will navigate you to Home screen. There was also an unused dependency lying in pubspec.yaml file, I removed it as well.

I have made the splash screens for your application. For splash screens to work I added new files such as a new model and a new controller to handle the navigating and the content of the splash screen.

It solves issue #4

#4

I tested my splash screen in multiple emulators of different sizes.

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1 Screenshot #2 Screenshot #3 Screenshot #4 Screenshot #5 Screenshot #6
TRUST TIME CONVINIENT EARN Categories Regulated Prices Recycle
Screenshot_1644602975 Screenshot_1644602977 Screenshot_1644602979 Screenshot_1644602980 Screenshot_1644602982 Screenshot_1644602984

Copy link
Owner

@Lakhankumawat Lakhankumawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟Code and work is great
Things i didn't expected and you did excellent for them as well

  • model class for splashitems which is good
  • I thought you would be using any other plugin for pagview but you didn't which is good thing

Overall Commits seems okay to me

@Lakhankumawat Lakhankumawat merged commit 1d32a2a into Lakhankumawat:master Feb 12, 2022
@Lakhankumawat
Copy link
Owner

Lakhankumawat commented Feb 12, 2022

Thanks for the Contribution
about the checkmarks so without any space you have to type x inside to get a checked checkmark like this

  • and also if you don't type x inside you can select & deselect them from outside
  • [x]
  • [ ]

@samitkapoor samitkapoor deleted the splashscreenapp branch February 12, 2022 07:12
@samitkapoor
Copy link
Contributor Author

@Lakhankumawat Thanks!
Actually, I am new and this was my first open-source contribution too, so I didn't know about the checkmarks lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants