Skip to content

Test/attester registry edge cases and error docs - #299

Open
aji70 wants to merge 4 commits into
Lafiya-xyz:mainfrom
aji70:test/attester-registry-edge-cases-and-error-docs
Open

Test/attester registry edge cases and error docs#299
aji70 wants to merge 4 commits into
Lafiya-xyz:mainfrom
aji70:test/attester-registry-edge-cases-and-error-docs

Conversation

@aji70

@aji70 aji70 commented Aug 27, 2026

Copy link
Copy Markdown

Summary

Adds test coverage for two previously-unconsidered edge cases in the attester-registry contract (self-referential admin/contract addresses as
attesters, and calling propose_admin twice before accept_admin), and improves the doc comments on the AllowlistFull and
InvalidRegistryWiring errors across both the attester-registry and attestation-registry contracts to give integrators actionable
remediation guidance.

Changes

#161 — Add edge-case tests for zero/self-referential addresses in attester-registry

  • Admin-address and contract-address add_attester tests, behavior documented per test with a one-line comment

#162 — Add a test for calling propose_admin twice before accept_admin

  • Overwrite-vs-reject behavior determined empirically and tested, doc comment added above propose_admin

#163 — Improve the AllowlistFull error doc comment with actionable remediation

  • Remediation paths (set_max_attesters / remove_attester) added to the doc comment, docs/error-codes.md synced

#164 — Improve the InvalidRegistryWiring error doc comment with remediation guidance

  • Remediation guidance added to the doc comment in attestation-registry, docs/error-codes.md synced

Closes #161, Closes #162, Closes #163, Closes #164

@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@aji70 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant