Test/attester registry edge cases and error docs - #299
Open
aji70 wants to merge 4 commits into
Open
Conversation
|
@aji70 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for two previously-unconsidered edge cases in the attester-registry contract (self-referential admin/contract addresses as
attesters, and calling
propose_admintwice beforeaccept_admin), and improves the doc comments on theAllowlistFullandInvalidRegistryWiringerrors across both the attester-registry and attestation-registry contracts to give integrators actionableremediation guidance.
Changes
#161 — Add edge-case tests for zero/self-referential addresses in attester-registry
add_attestertests, behavior documented per test with a one-line comment#162 — Add a test for calling propose_admin twice before accept_admin
propose_admin#163 — Improve the AllowlistFull error doc comment with actionable remediation
set_max_attesters/remove_attester) added to the doc comment,docs/error-codes.mdsynced#164 — Improve the InvalidRegistryWiring error doc comment with remediation guidance
attestation-registry,docs/error-codes.mdsyncedCloses #161, Closes #162, Closes #163, Closes #164