LibWeb+LibCrypto: Add Ed448 support in WebCryptoAPI #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADKaster
reviewed
Dec 23, 2024
|
After this goes in, a comment on WICG/webcrypto-secure-curves#20 seems appropriate |
devgianlu
force-pushed
the
ed448
branch
3 times, most recently
from
1a3dde2 to
fc1b5c5
Compare
rmg-x
reviewed
Dec 24, 2024
alimpfard
reviewed
Dec 24, 2024
ADKaster
reviewed
Dec 24, 2024
Add a couple of macros to aid error handling with OpenSSL and some RAII classes that manage the lifetime of some OpenSSL objects.
Implement the Ed448 curve for signing and verifying using OpenSSL. The methods could be all made static, but all other curves are not. I think this is material for further refactoring.
Add full support for Ed448 and import relevant tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the recently merged OpenSSL PR to implement Ed488 quick and easy.
Apart from implementing Ed448, I've also started defining some macros to aid development of code based on OpenSSL (see
OPENSSL_TRYandOPENSSL_TRY_PTR).The implemention is a bit different from the other curves obviously and now all the methods could be static. I have evaluated some possibilities:
OwnPtrs everywhereRSAand require to initialize it with the keys instead of passing them to the methodsI think the decision can wait based on how the implementation of other things using OpenSSL goes, but wanted to share.