Fixissue874 - #930
Merged
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All content routes (
/activity,/settings,/incoming,/streams/create,/streams/[id]) started with"use client", preventing them from exporting per-routemetadata. Every page shared the root<title>FlowFi | Real-time Payment Streams</title>regardless of content.Type of Change
Related Issues
Closes #874
Changes Made
For each of the 5 affected routes, split the page into a server component (
page.tsx) and a client component (*-content.tsx):activity/page.tsx— server component withtitle: "Activity | FlowFi", delegates toactivity-content.tsxsettings/page.tsx— server component withtitle: "Settings | FlowFi", delegates tosettings-content.tsxincoming/page.tsx— server component withtitle: "Incoming Streams | FlowFi", delegates toincoming-content.tsxstreams/create/page.tsx— server component withtitle: "Create Stream | FlowFi", delegates tocreate-stream-content.tsxstreams/[id]/page.tsx— server component withgenerateMetadatareturningtitle: "Stream #[id] | FlowFi", passesstreamIdas prop tostream-details-content.tsx(replacinguseParams())Testing
Test Coverage
Test Steps
/activity,/settings,/incoming,/streams/create, and/streams/[id]<title>tag for each — each should show a distinct titleChecklist
Additional Notes
No breaking changes. All interactive logic is preserved — only the
"use client"directive and metadata export were separated. Each new client component is colocated with its page for clarity.