Skip to content

test(stream): cover COMPLETED status and StreamEvent unique dedup - #929

Merged
ogazboiz merged 2 commits into
LabsCrypt:mainfrom
Caneryy:feat/issue-839
Jul 4, 2026
Merged

test(stream): cover COMPLETED status and StreamEvent unique dedup#929
ogazboiz merged 2 commits into
LabsCrypt:mainfrom
Caneryy:feat/issue-839

Conversation

@Caneryy

@Caneryy Caneryy commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Closes #839

Summary

  • [Testing] No test asserts @@unique([transactionHash,eventType]) dedup, and repository COMPLETED branch is untested

Test plan

  • Relevant tests pass locally
  • Manual verification on affected UI or API paths

@Caneryy Caneryy changed the title feat(flowfi): testing-no-test-asserts-unique-transactionhash-e test(stream): cover COMPLETED status and StreamEvent unique dedup Jun 29, 2026
@Caneryy

Caneryy commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@ogazboiz revier and merge please

@ogazboiz

ogazboiz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

heads up: main's ci was broken (the Backend CI and Backend Docker Image CI jobs) until the fixes in #969 and #974 just landed, so the red backend/docker checks on this pr are almost certainly stale, they ran against the broken main. please rebase to re-test against the now-green main: git fetch origin && git rebase origin/main && git push --force-with-lease. once it's green i'll review and merge. (if a non-backend check like Frontend CI is still red after the rebase, that part is a real issue worth a look, since frontend ci was passing on main.)

@Caneryy

Caneryy commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

all checks passed. review please. @ogazboiz

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid test coverage, the repository test covers the COMPLETED -> isActive:false branch and the integration test asserts the @@unique([transactionHash,eventType]) constraint (P2002) + worker-replay dedup, matching the real schema/worker behavior. merging.

@ogazboiz
ogazboiz merged commit d9dbcbf into LabsCrypt:main Jul 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Testing] No test asserts @@unique([transactionHash,eventType]) dedup, and repository COMPLETED branch is untested

2 participants