fix: dead Log In button, missing rel, window.location nav, missing AbortController - #596
Merged
ogazboiz merged 1 commit intoMay 30, 2026
Conversation
…window.location nav, missing AbortController - LabsCrypt#562: Remove non-functional Log In button from Navbar; WalletButton is the sole auth entry point - LabsCrypt#560: Add rel="noopener noreferrer" to Stellar Expert external link in ActivityHistory to prevent reverse-tabnabbing - LabsCrypt#561: Replace window.location.href with useRouter().push in NotificationDropdown and close dropdown on navigate - LabsCrypt#563: Add AbortController to activity page useEffect; pass signal to fetch and abort on tab change / unmount to prevent stale-response races Closes LabsCrypt#560 Closes LabsCrypt#561 Closes LabsCrypt#562 Closes LabsCrypt#563 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #560
Closes #561
Closes #562
Closes #563
What changed and why
#562 — Navbar: remove dead Log In button
The
Log Inbutton rendered with noonClickorhref— clicking it did nothing.WalletButtonis the real auth entry point so the orphaned button is removed.#560 — ActivityHistory: add
rel="noopener noreferrer"to Stellar Expert linkThe external explorer anchor had
target="_blank"with norel, exposing the app to reverse-tabnabbing. Fixed inActivityHistory.tsx. A grep confirmed every othertarget="_blank"link in the codebase already carries the correctrel.#561 — NotificationDropdown: replace
window.location.hrefwithrouter.pushThe "View All Activity" button was forcing a full-page reload, discarding SPA state (wallet context, React Query cache, SSE connection). Now uses
useRouter().push('/activity')fromnext/navigationand closes the dropdown before navigating.#563 — Activity page: add AbortController cleanup to fetch
fetchActivityhad no abort signal, so rapidly switching tabs or unmounting mid-flight left stale in-flight requests that could racesetEvents/setHasMore. AnAbortControlleris now created in the effect, itssignalpassed tofetch, andabort()called on cleanup.AbortErroris silently ignored.Files changed
frontend/src/components/Navbar.tsxfrontend/src/components/dashboard/ActivityHistory.tsxfrontend/src/components/NotificationDropdown.tsxfrontend/src/app/activity/page.tsxTest plan
window.opener