Skip to content

fix: dead Log In button, missing rel, window.location nav, missing AbortController - #595

Closed
MarvyNwaokobia wants to merge 1 commit into
LabsCrypt:mainfrom
MarvyNwaokobia:fix/frontend-issues-560-561-562-563
Closed

fix: dead Log In button, missing rel, window.location nav, missing AbortController#595
MarvyNwaokobia wants to merge 1 commit into
LabsCrypt:mainfrom
MarvyNwaokobia:fix/frontend-issues-560-561-562-563

Conversation

@MarvyNwaokobia

@MarvyNwaokobia MarvyNwaokobia commented May 30, 2026

Copy link
Copy Markdown

Summary

Fixes four independent frontend issues in a single PR:

Closes #560
Closes #561
Closes #562
Closes #563

Files changed

  • frontend/src/components/Navbar.tsx
  • frontend/src/components/dashboard/ActivityHistory.tsx
  • frontend/src/components/NotificationDropdown.tsx
  • frontend/src/app/activity/page.tsx

Test plan

  • Verify Navbar no longer shows a Log In button; WalletButton still renders correctly
  • Open ActivityHistory, click the external explorer link — confirm it opens in a new tab without exposing window.opener
  • Open NotificationDropdown, click "View All Activity" — confirm it navigates via the Next.js router (no full reload), and the dropdown closes
  • On the activity page, rapidly switch tabs — confirm no stale-response race conditions or console warnings about state updates after unmount

…window.location nav, missing AbortController

- LabsCrypt#562: Remove non-functional Log In button from Navbar; WalletButton is the sole auth entry point
- LabsCrypt#560: Add rel="noopener noreferrer" to Stellar Expert external link in ActivityHistory to prevent reverse-tabnabbing
- LabsCrypt#561: Replace window.location.href with useRouter().push in NotificationDropdown and close dropdown on navigate
- LabsCrypt#563: Add AbortController to activity page useEffect; pass signal to fetch and abort on tab change / unmount to prevent stale-response races

Closes LabsCrypt#560
Closes LabsCrypt#561
Closes LabsCrypt#562
Closes LabsCrypt#563

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@MarvyNwaokobia

Copy link
Copy Markdown
Author

Closing in favor of a new PR with proper issue linking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant