[Security Fix] ci: extend CodeQL analysis and cargo audit to Rust smart contracts - #1357
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Rust static analysis (CodeQL) and dependency vulnerability auditing (
cargo audit) for the Soroban smart-contract code in.github/workflows/security.yml. Previously, CodeQL only analyzed JavaScript and TypeScript, leaving the smart contract (the repository's primary attack surface) without CodeQL analysis.Type of Change
Related Issues
Resolves CodeQL missing Rust smart-contract analysis audit finding.
Changes Made
.github/workflows/security.ymlCodeQL matrix tolanguage: [ 'javascript', 'typescript', 'rust' ].dtolnay/rust-toolchain@stable) and build step (cargo check --workspace --all-targets) incontracts/for CodeQL indexing.cargo auditstep to thedependency-checkjob insecurity.ymlto auditcontracts/Cargo.lock.pull_requesttriggers insecurity.ymlto includedevelopbranch.Testing
Test Coverage
Test Steps
npm run verify-securityto verify security workflow and policy checks.cargo clippy --all-targets -- -D warningsincontracts/to confirm clean static analysis.cargo testincontracts/to verify all contract unit and property tests pass.Checklist
Additional Notes
Ran
npm run verify-securitylocally (6/6 passed) and verifiedcargo clippyandcargo testpass cleanly.Closes #1279