Skip to content

Fix stream wizard close - #1355

Merged
K1NGD4VID merged 2 commits into
LabsCrypt:mainfrom
Peolite001:fix-stream-wizard-close
Aug 30, 2026
Merged

Fix stream wizard close#1355
K1NGD4VID merged 2 commits into
LabsCrypt:mainfrom
Peolite001:fix-stream-wizard-close

Conversation

@Peolite001

Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue where the stream-creation wizard could be closed by the user mid-transaction, potentially causing them to abandon the UI and lose track of a pending stream creation. The wizard modal now correctly disables closing and gray-outs the "Cancel" button while a submission or indexing check is in flight, matching the behavior of sibling modals like TopUpModal.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issues

Closes #1226

Changes Made

  • Updated frontend/src/components/stream-creation/StreamCreationWizard.tsx:
    • Passed isCloseDisabled: isSubmitting || isPolling to the useModalDialog hook to prevent backdrop clicks and the escape key from dismissing the modal during in-flight transactions.
    • Added disabled={isSubmitting || isPolling} to the wizard's footer "Cancel" button.

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

  1. Navigate to the Stream Creation Wizard.
  2. Complete all required steps to create a stream.
  3. Click "Create Stream" to initiate the transaction.
  4. While the transaction or indexer polling is in flight, verify that the "Cancel" button is disabled.
  5. Attempt to click outside the modal (backdrop) or press the Escape key and verify that the modal does not close.

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Updated Postman/Hoppscotch API collections if routes changed
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

None.

@K1NGD4VID
K1NGD4VID merged commit f2549bb into LabsCrypt:main Aug 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Audit] Stream-creation wizard can be closed mid-transaction

2 participants