Fix stream wizard close - #1355
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the stream-creation wizard could be closed by the user mid-transaction, potentially causing them to abandon the UI and lose track of a pending stream creation. The wizard modal now correctly disables closing and gray-outs the "Cancel" button while a submission or indexing check is in flight, matching the behavior of sibling modals like
TopUpModal.Type of Change
Related Issues
Closes #1226
Changes Made
frontend/src/components/stream-creation/StreamCreationWizard.tsx:isCloseDisabled: isSubmitting || isPollingto theuseModalDialoghook to prevent backdrop clicks and the escape key from dismissing the modal during in-flight transactions.disabled={isSubmitting || isPolling}to the wizard's footer "Cancel" button.Testing
Test Coverage
Test Steps
Checklist
Additional Notes
None.