Fix overlapping stream fetches by tracking request ids - #1353
Merged
K1NGD4VID merged 1 commit intoAug 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where overlapping fetch requests for stream details and events (caused by rapid SSE bursts) could resolve out of order and apply stale data. Previously, the refresh effect created a new
AbortControlleron each update, but this didn't prevent an already in-flight, slower fetch from resolving late and overwriting newer state data within the same mount.Type of Change
Related Issues
Closes #1212
Changes Made
useReffor bothfetchStreamandfetchEventsinfrontend/src/app/streams/[id]/stream-details-content.tsx.fetchStreamandfetchEventscallbacks to check that the current request ID matches the latest request ID before applying the fetched data to state, safely discarding outdated overlapping responses.Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Checklist
Additional Notes
By explicitly tracking request IDs manually on the callbacks instead of heavily restructuring the
useEffectscope for aborts, this prevents overlapping state updates directly regardless of where the fetch callbacks are invoked from (e.g. initial loads, manual top-ups, SSE events).