fix(backend): cap unbounded findMany queries in summary and SSE subsc… - #1307
Merged
Conversation
…ribe Issue LabsCrypt#1246: Both getUserStreamSummary and SSE subscribe fetch all streams for a wallet with no take limit, causing unbounded DB queries when a wallet has thousands of streams. - Add MAX_USER_STREAMS (500) cap to getUserStreamSummary with orderBy startTime desc so the most recent streams are always included - Add MAX_SSE_STREAMS (500) cap to SSE subscribe with orderBy startTime desc - Both queries now include a documented take limit and the summary response includes a truncated flag when the cap is hit - Add tests proving a wallet with more streams than the cap only fetches up to the cap and the truncated flag is set correctly - Existing claimable-amount calculation and SSE behavior remain correct within the bounded result set 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
…imports in stream controller test The merge from main reverted the import line in stream.controller.test.ts, dropping getUserStreamSummary and MAX_USER_STREAMS while keeping the test cases that reference them. This caused TS2304 errors in the Backend CI build and runtime ReferenceError in Backend npm test. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1246
Summary
Testing