test: cover wallet-gated dashboard entry and recipient deep-link prefill - #1127
Merged
ogazboiz merged 1 commit intoJul 29, 2026
Merged
Conversation
- Add WalletEntry tests for the pre-hydration, no-session, and connected-session states so the wallet-gate behavior on /dashboard is pinned down. - Add recipient query-param prefill to the create-stream form (used for "pay this address" deep links), validating the address with StrKey and ignoring malformed values instead of crashing, with tests for the valid, malformed, and absent-param cases. Closes LabsCrypt#1112 Closes LabsCrypt#1113 stream.repository.ts has no top-up read-modify-write path yet (LabsCrypt#1111 describes a race in logic that doesn't exist in this codebase), so no change was made for that one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WalletEntrycovering the pre-hydration loading state, the no-session state (wallet-connect modal shown), and the connected-session state (dashboard rendered).?recipient=query param on the create-stream page (for "pay this address" deep links), validated withStrKey.isValidEd25519PublicKeyand ignored gracefully when malformed, with tests for valid/malformed/absent param cases.stream.repository.tscurrently has no top-up read-modify-write logic to raceTest plan
npx vitest runinfrontend/— all new and existing tests passCloses [Testing] No test covers concurrent top-up requests on the same stream racing against each other at the repository layer #1111
Closes [Testing] frontend/src/app/dashboard/page.tsx has no test verifying it redirects or prompts wallet connection when no wallet session exists #1112
Closes [Testing] frontend/src/app/streams/create/page.tsx has no test verifying a deep-linked prefilled recipient query param is applied to the form #1113