fix: improve accessibility and error handling in progress bar, streaming amount, and soroban client - #1126
Merged
ogazboiz merged 1 commit intoJul 29, 2026
Conversation
…ing amount, and soroban client Closes LabsCrypt#1121 Closes LabsCrypt#1120 Closes LabsCrypt#1119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aria-label/aria-valuetextto the progress bar inProgressbar.tsx(it already hadrole="progressbar"and thearia-value*min/now/max attributes), so screen readers announce a description alongside the current progress value.isContractNotFoundErrorinsoroban.ts) and a dedicatedContractNotFounderror code with a clear, actionable message, applied to both the token-balance simulation and the general contract-call simulation paths.useStreamingAmountnow listens forvisibilitychangeand skips recomputation whiledocument.hiddenis true, then resyncs the displayed amount to the true elapsed-time value (instead of resuming from a stale tick) when the tab becomes visible again.**#1118 **:
useModalDialog.tscapturesdocument.activeElementon open and restores focus to it on close/unmount (see the existingpreviouslyFocusedReflogic and the passing "should restore focus to previously focused element on unmount" test) — no change needed.Test plan
npx vitest runfor the touched files — all pass (Progressbar, useStreamingAmount, soroban, useModalDialog)npx tsc --noEmit— no new errors in changed files (two pre-existing unrelated test-file failures inuseIncomingStreams.test.ts/ another.tstest using JSX are out of scope)Closes #1121
Closes #1120
Closes #1119
Closes #1118