Saved opportunities integration, individual opportunity view, opportunity context rework

[WBroadwell]

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Saved opportunities integrated into Opportunities page. Also integrated save and unsave buttons. Individual opportunity view tied to profile view and opportunity view buttons with backend route integration. OpportunityContext reowrk for all of the oppoortunity components.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Rigorously on local machine

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works (if a larger change)
• New and existing unit tests pass locally with my changes

[Copilot]

Pull request overview

This PR refactors the opportunities feature by centralizing state management using React Context, integrating saved opportunities into the main Opportunities page, and consolidating type definitions. The changes remove the standalone /saved route and instead provide a tabbed interface on the Opportunities page to switch between "Search" and "Saved" views.

Key Changes:

• Introduced OpportunityContext with useReducer for centralized opportunity state management (filters, query, opportunities list)
• Integrated saved opportunities as a tab within the Opportunities page, removing the separate /saved route
• Refactored type definitions by splitting opportunities.ts into separate filters.ts and updated opportunity.ts files

Reviewed changes

Copilot reviewed 16 out of 19 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tsconfig.json	Changed moduleResolution from "node" to "bundler" for improved module resolution
src/types/opportunityaction.ts	New file defining action types for the opportunity reducer
src/types/opportunity.ts	Updated type definition with consistent property types and added saved field
src/types/opportunities.ts	Removed file, split into separate type files
src/types/filters.ts	New file containing the Filters type extracted from opportunities.ts
src/shared/components/Navigation/MainNavigation.tsx	Removed "Saved" navigation link
src/shared/components/Checkbox.tsx	Updated import path and removed "semesters" filter check
src/opportunities/pages/Opportunities.tsx	Wrapped with OpportunityProvider and integrated SavedPage as a tab
src/opportunities/components/SearchBar.tsx	Removed standalone SearchBar component
src/opportunities/components/Posts.tsx	Refactored to use OpportunityContext instead of local reducer
src/opportunities/components/PopUpMenu.tsx	Updated to consume context instead of receiving props
src/opportunities/components/OpportunitiesList.tsx	Added save/unsave functionality with API integration
src/opportunities/components/FiltersField.tsx	Integrated inline search form and moved to context-based state
src/individuals/pages/Saved.tsx	Updated styling to match OpportunitiesList table design
src/context/useOpportunity.tsx	New custom hook for accessing OpportunityContext
src/context/OpportunityContext.tsx	New context provider managing opportunity state with useReducer
src/App.tsx	Removed /saved route

Comments suppressed due to low confidence (6)

src/opportunities/components/OpportunitiesList.tsx:4

• Unused import OpportunityAction. This should be removed if it's not needed.
  src/opportunities/components/OpportunitiesList.tsx:1
• Unused imports useState and useEffect. These should be removed if they're not needed.
  src/opportunities/components/OpportunitiesList.tsx:64
• The optimistic update in the finally block is incorrect. It should happen before the API call (optimistic), not after. Currently, if the API call fails, the UI still updates. The update should either happen before the fetch (true optimistic) with a rollback on error, or after a successful response (pessimistic). The current implementation updates the UI regardless of success or failure.
  src/opportunities/components/OpportunitiesList.tsx:24
• Multiple console.log statements should be removed from production code. Found at lines 14, 20, 24, 27, 41, 54, and 63.
  src/opportunities/components/OpportunitiesList.tsx:1
• Unused imports useEffect, useState.
  src/opportunities/components/OpportunitiesList.tsx:4
• Unused import OpportunityAction.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The ternary operator logic is incorrect. The expression (name === "years" && filters?.years?.includes(Number(item))) || (name === "credits" && filters?.credits?.includes(item) ? true : false) has incorrect operator precedence. The ternary operator binds to only the second condition, not the entire OR expression. This should be: ((name === "years" && filters?.years?.includes(Number(item))) || (name === "credits" && filters?.credits?.includes(item))) ? true : false or simply (name === "years" && filters?.years?.includes(Number(item))) || (name === "credits" && filters?.credits?.includes(item)).

Suggested change

	defaultChecked={(name === "years" && filters?.years?.includes(Number(item))) || (name === "credits" && filters?.credits?.includes(item) ? true : false)}
	defaultChecked={(name === "years" && filters?.years?.includes(Number(item))) || (name === "credits" && filters?.credits?.includes(item))}

[Copilot]

Debug console.log statements should be removed from production code (lines 32 and 36).

[Copilot]

The initial state hardcodes "2025" and [2025] instead of using currYr (defined on line 7), which means the initial filters won't update when the year changes. Replace "2025" with currYr.toString() and [2025] with [currYr] for consistency with the RESET_FILTERS action.

Suggested change

	activeFilters: ["2025"],
	filterMap: { years: [2025], credits: [], hourlyPay: 0, majors: [] },
	activeFilters: [currYr.toString()],
	filterMap: { years: [currYr], credits: [], hourlyPay: 0, majors: [] },

[Copilot]

The useEffect has an empty dependency array but should include fetchSaved in its dependencies, or better yet, define fetchSaved inside the useEffect to avoid the stale closure issue. Additionally, the fetchSaved function should be wrapped with useCallback if it remains outside.

[Copilot]

The query field in state is set but never exposed through the context provider. It should be added to the OpportunityContextType interface and the context provider value to be usable by consuming components.