Will-Frontend

[WBroadwell]

Filter functionality for jobs

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Running front end and testing adding and removing the filters

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works (if a larger change)
• New and existing unit tests pass locally with my changes

[RafaelCenzano]

Overall things look good, could you include a picture of the new UI? And can you fix the eslint issues on these files.

[WBroadwell]

lmk if you want the image somewhere in the documents, cancel leaves filters as is, search updates them based on choices and the clear button outside resets to initial list

eslint should be good now, saw proptypes being required for tsx files, u want me to swap the rest of the js components over to tsx and make the proptypes for them?

[RafaelCenzano]

Yeah if possible any js files these use should tsx.

Is the filters missing the years? Could we also add a clear/reset to defaults button. And if possible adding defaults for the current semester and year.

Could you also add the majors?

[WBroadwell]

I set the years up to fetch from backend, tested that it works if i enter the years as the initial but i figured i shouldn't leave that for the pr. I can add all that and work on converting the js to tsx, you want me to cancel the pr and add everything or merge then open fresh branch?

[WBroadwell]

Also, ik u mentioned using the fetch years from the backend but i could use a react function to get the current year then subtract to get the others if thats easier/more error proof

[RafaelCenzano]

I set the years up to fetch from backend, tested that it works if i enter the years as the initial but i figured i shouldn't leave that for the pr. I can add all that and work on converting the js to tsx, you want me to cancel the pr and add everything or merge then open fresh branch?

The lining is passing for now so that's good. If you want to make a separate pr to convert things to tsx that would be great. I've just been doing it as I've been updating pages.

[WBroadwell]

new ui, filters title and buttons arent in the scroll. lmk if you want me to remove any of the majors since idk if some of them will have research or if we should just keep them all. ill start work on tsx tmr.

one other thing ab current semester, rn i have january-may as spring and june-august as summer. not sure if thats exactly right with dates or if its good enough, lmk if i should update it