Pushing course data to DB & Added logging #288
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
RafaelCenzano
left a comment
RafaelCenzano
left a comment
There was a problem hiding this comment.
Overall looking good check the few comments I added. I'd also recommend using ruff, it should be installed in the venv. you can run with ruff check to see issues. ruff format should help fix most lint errors.
db_init.py
Outdated
| import sys | ||
| import requests | ||
|
|
||
| from sqlalchemy import create_engine |
There was a problem hiding this comment.
Echoing the ruff comment, this should be removed since it's not needed/used
db_init.py
Outdated
|
|
||
| if new_courses: | ||
| session.add_all(new_courses) | ||
| session.commit() |
There was a problem hiding this comment.
for session.commit, move that into the if statement since we only need it in the if statement
db_init.py
Outdated
| with app.app_context(): | ||
| db.create_all() | ||
|
|
||
| json_url = "https://raw.githubusercontent.com/quacs/quacs-data/master/semester_data/202409/catalog.json" |
There was a problem hiding this comment.
can you update this function to intake the URL as an argument, should check if sys.argv[2] is present (add logic to confirm extra arguments exist). Add logic to confirm that it's a URL.
|
You should also try to merge from main too just so your code is up to date before merging |
|
I addressed the major errors, I think it should be resolved. I'm not sure if the checks are updated. |
2 participants
Description & Fixes # (issue)
Pushing course data to DB:
In db_init.py, added an argument for addCourses to add courses from json endpoint to database. Updated functions and addCourses code. I found a case in which course_code has a string of length 9.
Course data can now be pushed to the Database, course_code only accepts string of length 8 to account for course_code errors. Course data is only added to the DB, if not found in the DB.
Added logging:
Added logging with app.logger that logs information for initialization and functions in init.py file,
Type of change
How Has This Been Tested?
In powershell:
Run python db_init.py addCourses
In wsl:
Run python3 db_init.py addCourses
Checklist: