236 registration page #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…portunities to add new leads. Also attempted to fix registration.
…Backend into 236-registration-page
Closed
|
Here's the code health analysis summary for commits Analysis Summary
|
RafaelCenzano
requested changes
Nov 12, 2024
labconnect/main/auth_routes.py
Outdated
| json_data = request.get_json() | ||
| user.first_name = json_data.get("first_name") | ||
| user.last_name = json_data.get("last_name") | ||
| user.preferred_name = json_data.get("preferred_name") |
Member
There was a problem hiding this comment.
For some of these we should add default values for example preferred_name should be blank if empty I believe
labconnect/main/auth_routes.py
Outdated
| user.last_name = json_data.get("last_name") | ||
| user.preferred_name = json_data.get("preferred_name") | ||
| user.class_year = json_data.get("class_year") | ||
| user.profile_picture = json_data.get("profile_pictures") |
Member
There was a problem hiding this comment.
If not profile picture is added we should add the default we have been using for test users
labconnect/main/auth_routes.py
Outdated
| def registerUser(): | ||
| user_id = get_jwt_identity() | ||
|
|
||
| user = db.session.execute(db.select(User).where(User.email == user_id)) |
Member
There was a problem hiding this comment.
We should be making a new User instead of requesting an existing one, all logic for making a user should be here.
labconnect/main/auth_routes.py
Outdated
| email=user_id, | ||
| first_name=json_data.get("first_name"), | ||
| last_name=json_data.get("last_name"), | ||
| preferred_name=json_data.get("preferred_name"), |
Member
There was a problem hiding this comment.
We should add major as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Added registration for new users. I also added the search route for lab managers and the updated create and edit opportunity routes to allow more lab managers to be added.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: