forked from rbugalho/sw_daq_tofhir2
-
Notifications
You must be signed in to change notification settings - Fork 3
Update documentation and changes to get system running at UVA #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
btcardwell
wants to merge
19
commits into
Lab5015:tofhir2b
Choose a base branch
from
btcardwell:tofhir2b-uva-squashed
base: tofhir2b
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains a new readme file that explains to a new user how to go from git clone to taking data. It also contains many small changes to the code to simplify procedures and get it to work at UVA. See below for a list of changes: - increase interval between test pulses during tdc calibration. We don't fully understand this fix, but it is necessary to use TOFHIR2X with the latest sw and fw at Caltech and UVA - update gitignore to remove swp, png, root, etc - add readme - create config subdirectory that contains default config.ini, bias_settings_aldo.tsv, map_channel.tsv, map_trigger.tsv - use python3 print statements in a few files - get GUI to run - add --keithley-model and --keithley-ip-address arguments to scan_aldo_hv, acquire_sipm_stressTest, and acquire_sipm_IV_scan - fixed bug in scan_aldo_hv due to Windows line endings - add --data-dir argument to acquire_sipm_data_scan and convert.py - create data directory structure and last_run if they don't exist - try to simplify create_ALDO_calibration_combined. - add try-excepts to help with importing from Lab5015Utils in scan_aldo_hv Note that most of these changes should be backward compatible, but watch out for the following: - --keithley-ip-address should be specified at least once (the IP address is stored in ~/.keithley_ip_address.txt and only needs to be specified once) - create_ALDO_calibration_combined used to require hand editing and moving files. It can now be run with ```create_ALDO_calibration_combined.py aldo_scan_ASIC*tsv --dest-dir ../config```
2114968 to
e42251c
Compare
Bring in updates to include Ricardo's fix for external triggers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains a new readme file that explains to a new user how to go
from git clone to taking data. It also contains many small changes to the code
to simplify procedures and get it to work at UVA. See below for a list of
changes:
understand this fix, but it is necessary to use TOFHIR2X with the latest
sw and fw at Caltech and UVA
bias_settings_aldo.tsv, map_channel.tsv, map_trigger.tsv
scan_aldo_hv, acquire_sipm_stressTest, and acquire_sipm_IV_scan
Note that most of these changes should be backward compatible, but watch out
for the following:
stored in ~/.keithley_ip_address.txt and only needs to be specified once)
files. It can now be run with
create_ALDO_calibration_combined.py aldo_scan_ASIC*tsv --dest-dir ../config