Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude self newspace from oldspace decomposition #6321

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

wwylele
Copy link
Contributor

@wwylele wwylele commented Jan 11, 2025

This partially fixes #6104 in the affected newspace pages (knowl still has the problem). I chose the approach to keep this as oldspace decomposition and remove the extra self newspace. I find it better to keep the semantics of this section, as it contrast with the previous section ("Decomposition of $S^{new}$" and "Decomposition of $S^{old}$")

@AndrewVSutherland
Copy link
Member

@wwylele if you email me at [email protected] I can send you a token you can use to create an account that will let you make knowl edits, and also an invite to the LMFDB zulip.

@AndrewVSutherland
Copy link
Member

I would also encourage you to add yourself to https://github.com/LMFDB/lmfdb/blob/main/CONTRIBUTORS.yaml (you can do that in this PR if you wish).

@AndrewVSutherland AndrewVSutherland added the CMF Classical modular forms label Jan 11, 2025
@wwylele
Copy link
Contributor Author

wwylele commented Jan 11, 2025

Thanks! I added myself there

@wwylele
Copy link
Contributor Author

wwylele commented Jan 11, 2025

I also submitted an edit to https://beta.lmfdb.org/knowledge/show/cmf.decomposition.old.gamma1. I kept the decomposition of the full space there because I find it less wordy

@AndrewVSutherland
Copy link
Member

Sorry for the delay, I'm reviewing this now and expect to merge it shortly (@edgarcosta can you hold off pushing to dev until that happens? It looks like there are some test failures in any case).

@AndrewVSutherland AndrewVSutherland merged commit 98038fc into LMFDB:main Jan 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMF Classical modular forms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in decomposition formula for classical modular forms
2 participants