Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for issue #4943 #6268

Merged
merged 3 commits into from
Nov 20, 2024
Merged

fixes for issue #4943 #6268

merged 3 commits into from
Nov 20, 2024

Conversation

JohnCremona
Copy link
Member

This addresses #4943 for ECQ. For the two lists of invariants to look consistent I added a symbol/name for all the quantities there, not just the real ones which may be approximate. All now do have names except the Sato-Tate group, and the same names appear in the appropriate knowls so a couple of those have had minor edits (Szpiro ratio, abc-quality). We could show something like ST(E) for the ST group of that is suffiently standard -- @AndrewVSutherland ?

I fixed but left the "(exact)"/"(rounded)" for analytic Sha since the knowl (originally written just for this purpose) does say something concrete, which is not obvious, namely that for both rank 0 and rank 1 the quantity shown is exact, having been computed as a rational, while for ranks 2 and above it is a rounded floating point number (not known theoretically to even be rational, let alone integral). I think this is markedly different from all the other approximate reals on the page. But of course I am willing to be persuaded!

Once this is done (with further changes if desired) I will do the same thing for ECNF.

@AndrewVSutherland
Copy link
Member

I think ST(E) is fine.

@roed314
Copy link
Contributor

roed314 commented Nov 19, 2024

Should there also be symbols for conductor, discriminant and $$j$$-invariant? I agree that "(exact)" / "(rounded)" are good as is.

@JohnCremona
Copy link
Member Author

JohnCremona commented Nov 19, 2024

Should there also be symbols for conductor, discriminant and j -invariant? I agree that "(exact)" / "(rounded)" are good as is.

I have put in "ST(E) = " with ST in mathrm and E in math mode.

About N, $\Delta$, j: yes for consistency, but consider this: these 3 have both values (integer or rational) and their factorization in a separate column. So after this extra change, either we put the factorizations into the same column as the value after " = ", with the equals not aligning; or we add a column. The latter would then require more work if you look at what happens after clicking on one of the code buttons: the code already appears in an extra, usually invisible column, and after the change (2nd option) all the code would be pushed further over.

I will try the first option and update the PR if it looks acceptable, otherwise I will try the second. I may even make a second branch so you can look at both.

Update: it was not as hard as I had thought to do both together using some "colspan=3" in the right places. Is this good now?

@roed314
Copy link
Contributor

roed314 commented Nov 20, 2024

Looks great!

@roed314 roed314 merged commit c8be045 into LMFDB:main Nov 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants