Skip to content

Conversation

@kapoorabhishek24
Copy link
Contributor

@kapoorabhishek24 kapoorabhishek24 commented Dec 5, 2025

The OTEL Collector config values (url.domain, lit.subnet.id) were being set via sed replacement in
common.sh. This was fragile because Salt could overwrite the file on subsequent runs, resetting the values to placeholders.

Changes

Refactored to use Salt grains for dynamic configuration:

  • common.sh: Sets grains during guest creation instead of sed-patching the config file
  • otel-collector-config.yaml.j2: New Jinja2 template that reads values from grains
  • init.sls: Updated to render the template with Jinja

@kapoorabhishek24 kapoorabhishek24 changed the title Fix guest labels Fix: Use Salt Grains for OTEL Collector Config Values Dec 12, 2025
@kapoorabhishek24 kapoorabhishek24 marked this pull request as ready for review December 12, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants