ci: testing snapshot container#691
Closed
joshLong145 wants to merge 7 commits intomasterfrom
Closed
Conversation
added 6 commits
October 16, 2024 08:35
Ansonhkg
reviewed
Oct 17, 2024
Contributor
Ansonhkg
left a comment
There was a problem hiding this comment.
Is the volume a blocker to getting this PR merged?
Author
The container used in this PR was published as a test. But does provide some improvements to CI times as you no longer need to install modules for lit assets. The test container was published to a tag so it should persist if you want to merge this pr as is, if not can be closed. |
|
Josh Long seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testing new container with snapshot in ci
Snap shots now load and work, speeding up ci. but volume is still needed for an unknown reason see pr: https://github.com/LIT-Protocol/lit-assets/pull/1518
This pr removes the need to run
npm installwithiniit-assets/blockchain/contractsand removes the deployment step replaced with loading state from snapshot.