Skip to content

Check if nbMeshingEdges are compatible when splitting faces #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check if nbMeshingEdges are compatible when splitting faces #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Core/Topo/TopoHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,9 +827,19 @@ void TopoHelper::splitFaces(std::vector<CoFace* > cofaces,

// réciproque: recherche la CoEdge touchée par le noeud
if (0 != edge_ar){
if (edge_dep->getNbMeshingEdges() != edge_ar->getNbMeshingEdges())
{
TkUtil::UTF8String messErr (TkUtil::Charset::UTF_8);
messErr << "Echec lors du découpage de la face "<<coface->getName()
<<", le nombre d'arêtes de maillage est différent de part et d'autre de la face (" << (short)edge_dep->getNbMeshingEdges()
<< " vs " << (short)edge_ar->getNbMeshingEdges() << ")";
throw TkUtil::Exception(messErr);
}

edge_ar->computeCorrespondingCoEdgeAndNbMeshingEdges(vertex2, nbMeshingEdges_edge, coedge_after_cut,
coedge_ar, nbMeshingEdges_ar, sens_coedge_ar);


#ifdef _DEBUG_SPLIT
std::cout<<"nbMeshingEdges_ar = "<<nbMeshingEdges_ar<<std::endl;
std::cout<<"coedge_ar = "<<coedge_ar->getName()<<std::endl;
Expand All @@ -844,7 +854,6 @@ void TopoHelper::splitFaces(std::vector<CoFace* > cofaces,
std::cout<<"edge_ar et coedge_ar == 0\n";
#endif
}

// on recherche si cette face est déjà coupée
InfoSplit* is = cofaceInfoSplit[coface->getUniqueId()];

Expand Down
42 changes: 42 additions & 0 deletions test_link/test_issue78.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
import pyMagix3D as Mgx3D
import pytest

def test_issue78(capfd):
ctx = Mgx3D.getStdContext()
ctx.clearSession() # Clean the session after the previous test

# Création du sommet Pt0000
ctx.getGeomManager().newVertex (Mgx3D.Point(0, 0, 0))
# Création du sommet Pt0001
ctx.getGeomManager().newVertex (Mgx3D.Point(1, 0, 0))
# Création du sommet Pt0002
ctx.getGeomManager().newVertex (Mgx3D.Point(1, 2, 0))
# Création du sommet Pt0003
ctx.getGeomManager().newVertex (Mgx3D.Point(0, 2, 0))
# Création du segment Crb0000
ctx.getGeomManager().newSegment("Pt0000", "Pt0001")
# Création du segment Crb0001
ctx.getGeomManager().newSegment("Pt0001", "Pt0002")
# Création du segment Crb0002
ctx.getGeomManager().newSegment("Pt0002", "Pt0003")
# Création du segment Crb0003
ctx.getGeomManager().newSegment("Pt0003", "Pt0000")
# Création de la surface Surf0000
ctx.getGeomManager().newPlanarSurface( ["Crb0000", "Crb0001", "Crb0002", "Crb0003"] , "")
# Création d'une face topologique structurée sur une géométrie (Surf0000)
ctx.getTopoManager().newStructuredTopoOnGeometry ("Surf0000")
# Découpage de l'arête Ar0000
ctx.getTopoManager().splitEdge ("Ar0000", .4)
# Découpage de la face Fa0000 par prolongation
ctx.getTopoManager().extendSplitFace ("Fa0000", "Som0004")
assert ctx.getTopoManager().getNbFaces()==2
ctx.undo()
assert ctx.getTopoManager().getNbFaces()==1
# Changement de discrétisation pour les arêtes Ar0002
emp = Mgx3D.EdgeMeshingPropertyUniform(3)
ctx.getTopoManager().setMeshingProperty (emp,["Ar0002"])
with pytest.raises(RuntimeError) as excinfo:
# Impossible car les discrétisations ne sont pas compatibles
ctx.getTopoManager().extendSplitFace ("Fa0000", "Som0004")
expected = "Echec lors du découpage de la face Fa0000, le nombre d'arêtes de maillage est différent de part et d'autre de la face (10 vs 3)"
assert expected in str(excinfo.value)