Issue #790: Fix entityIdPath

bases/lif/mdr_restapi/transformation_endpoint.py

@@ -24,7 +24,10 @@
 async def create_transformation(
     data: CreateTransformationDTO, response: Response, session: AsyncSession = Depends(get_session)
 ):
-    transformation = await transformation_service.create_transformation(session, data)
+    if data.TargetAttribute.EntityIdPath.__contains__(","):
+        transformation = await transformation_service.create_transformation_with_portable_entity_id_path(session, data)
+    else:
+        transformation = await transformation_service.create_transformation(session, data)
     # Set the Location header with the new entity association ID
     response.headers["Location"] = f"/transformation_groups/transformations/{transformation.Id}"
     return transformation

components/lif/mdr_dto/transformation_dto.py

@@ -1,8 +1,8 @@
-from pydantic import BaseModel
-from typing import List, Optional
 from datetime import datetime
+from typing import List, Optional
 
 from lif.datatypes.mdr_sql_model import ExpressionLanguageType
+from pydantic import BaseModel
 
 
 class TransformationAttributeDTO(BaseModel):
@@ -24,7 +24,7 @@ class Config:
 
 
 class CreateTransformationAttributeDTO(BaseModel):
-    AttributeId: int
+    AttributeId: Optional[int] = None  # No longer used
     EntityId: Optional[int] = None  # Existing column
     # AttributeName: Optional[str] = None
     # EntityName: Optional[str] = None

components/lif/mdr_services/entity_association_service.py

@@ -1,4 +1,5 @@
 from typing import List, Optional
+
 from fastapi import HTTPException
 from lif.datatypes.mdr_sql_model import DataModel, DataModelType, Entity, EntityAssociation, ExtInclusionsFromBaseDM
 from lif.mdr_dto.entity_association_dto import (
@@ -11,9 +12,8 @@
 from lif.mdr_services.helper_service import check_datamodel_by_id, check_entity_by_id
 from lif.mdr_utils.logger_config import get_logger
 from sqlalchemy.ext.asyncio import AsyncSession
-from sqlmodel import or_, select
 from sqlalchemy.orm import aliased
-
+from sqlmodel import or_, select
 
 logger = get_logger(__name__)
 
@@ -61,6 +61,20 @@ async def check_existing_association(
     return result.scalar_one_or_none() is not None
 
 
+async def check_entity_association_strict(
+    session: AsyncSession, parent_entity_id: int, child_entity_id: int, extended_by_data_model_id: int | None
+) -> bool:
+    query = select(EntityAssociation).where(
+        EntityAssociation.ParentEntityId == parent_entity_id,
+        EntityAssociation.ChildEntityId == child_entity_id,
+        EntityAssociation.Deleted == False,
+        EntityAssociation.ExtendedByDataModelId == extended_by_data_model_id,
+    )
+    result = await session.execute(query)
+    return result.scalar_one_or_none() is not None
+
+
+# TODO: Should any of this go into check_transformation_attribute()?
 async def validate_entity_associations_for_transformation_attribute(
     session: AsyncSession, transformation_attribute: TransformationAttributeDTO
 ) -> bool:

components/lif/mdr_services/entity_attribute_association_service.py

@@ -1,6 +1,6 @@
 from typing import List, Optional, Tuple
+
 from fastapi import HTTPException
-from sqlalchemy import Select, func, or_, select
 from lif.datatypes.mdr_sql_model import (
     Attribute,
     DataModelType,
@@ -15,6 +15,7 @@
 )
 from lif.mdr_services.helper_service import check_attribute_by_id, check_datamodel_by_id, check_entity_by_id
 from lif.mdr_utils.logger_config import get_logger
+from sqlalchemy import Select, func, or_, select
 from sqlalchemy.ext.asyncio import AsyncSession
 
 logger = get_logger(__name__)
@@ -41,6 +42,19 @@ async def check_existing_association(
     return result.scalar_one_or_none() is not None
 
 
+async def check_entity_attribute_association_strict(
+    session: AsyncSession, entity_id: int, attribute_id: int, extended_by_data_model_id: int | None
+) -> bool:
+    query = select(EntityAttributeAssociation).where(
+        EntityAttributeAssociation.EntityId == entity_id,
+        EntityAttributeAssociation.AttributeId == attribute_id,
+        EntityAttributeAssociation.Deleted == False,
+        EntityAttributeAssociation.ExtendedByDataModelId == extended_by_data_model_id,
+    )
+    result = await session.execute(query)
+    return result.scalar_one_or_none() is not None
+
+
 async def create_entity_attribute_association(session: AsyncSession, data: CreateEntityAttributeAssociationDTO):
     # checking if provided entity id and attribute id exist or not
     entity = await check_entity_by_id(session=session, id=data.EntityId)

components/lif/mdr_services/helper_service.py

@@ -58,6 +58,24 @@ async def check_entity_attribute_association(session: AsyncSession, entity_id: i
     return associations
 
 
+async def check_entity_attribute_association_with_model(
+    session: AsyncSession, entity_id: int, attribute_id: int, extended_by_data_model_id: int
+):
+    query = select(EntityAttributeAssociation).where(
+        EntityAttributeAssociation.EntityId == entity_id,
+        EntityAttributeAssociation.AttributeId == attribute_id,
+        EntityAttributeAssociation.ExtendedByDataModelId == extended_by_data_model_id,
+    )
+    result = await session.execute(query)
+    associations = result.fetchall()
+    if not associations:
+        raise HTTPException(
+            status_code=404,
+            detail=f"EntityAttributeAssociation with EntityId {entity_id} and AttributeId {attribute_id} not found",
+        )
+    return associations
+
+
 async def check_value_set_by_id(session: AsyncSession, id: int):
     value_set = await session.get(ValueSet, id)
     if not value_set:

components/lif/mdr_services/inclusions_service.py

@@ -1,12 +1,12 @@
 from fastapi import HTTPException
+from lif.datatypes.mdr_sql_model import DatamodelElementType, EntityAttributeAssociation, ExtInclusionsFromBaseDM
 from lif.mdr_dto.inclusion_dto import CreateInclusionDTO, InclusionDTO, UpdateInclusionDTO
 from lif.mdr_services.attribute_service import get_attribute_by_id
 from lif.mdr_services.entity_service import get_entity_by_id
 from lif.mdr_services.helper_service import check_datamodel_by_id
 from lif.mdr_utils.logger_config import get_logger
 from sqlalchemy.ext.asyncio import AsyncSession
-from lif.datatypes.mdr_sql_model import EntityAttributeAssociation, ExtInclusionsFromBaseDM
-from sqlmodel import select, func
+from sqlmodel import func, select
 
 logger = get_logger(__name__)
 
@@ -229,3 +229,16 @@ async def get_attribute_inclusions_by_data_model_id_and_entity_id(
     inclusions = result.scalars().all()
     inclusion_dtos = [InclusionDTO.from_orm(inclusion) for inclusion in inclusions]
     return inclusion_dtos
+
+
+async def check_existing_inclusion(
+    session: AsyncSession, type: DatamodelElementType, node_id: int, included_by_data_model_id: int
+) -> bool:
+    query = select(ExtInclusionsFromBaseDM).where(
+        ExtInclusionsFromBaseDM.ExtDataModelId == included_by_data_model_id,
+        ExtInclusionsFromBaseDM.IncludedElementId == node_id,
+        ExtInclusionsFromBaseDM.ElementType == type,
+        ExtInclusionsFromBaseDM.Deleted == False,
+    )
+    result = await session.execute(query)
+    return result.scalar_one_or_none() is not None