Skip to content

328 Add schema and dynamic_models components #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mryoho wants to merge 4 commits into
base: main
Choose a base branch
from
Open

328 Add schema and dynamic_models components #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb6f4f1
Improve some string_utils functions and add tests
Jan 26, 2026
ed6ffe1
Add 'schema' polylith component and tests
Jan 26, 2026
22b35cf
Add 'dynamic_models' polylith component and tests
Jan 26, 2026
3b4bf36
Register new polylith components in pyproject.toml
Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions components/lif/datatypes/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
from dataclasses import dataclass
from typing import Any, Dict

Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing blank line after imports. According to PEP 8, there should be two blank lines between the imports and the class definition. Add one more blank line after line 2.

Suggested change

Copilot uses AI. Check for mistakes.
@dataclass
class SchemaField:
"""Represents a single schema field, including its path and attributes."""

json_path: str
description: str
attributes: Dict[str, Any]
py_field_name: str = ""
Comment on lines +4 to +11
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SchemaField is not exported from the datatypes module. For consistency with other datatypes in this module (like IdentityMapping, LIFFragment, etc.), SchemaField should be added to the init.py imports and all list in components/lif/datatypes/init.py. This would allow users to import it as from lif.datatypes import SchemaField instead of requiring the more verbose from lif.datatypes.schema import SchemaField.

Copilot uses AI. Check for mistakes.
3 changes: 3 additions & 0 deletions components/lif/dynamic_models/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from lif.dynamic_models import core

__all__ = ["core"]
Loading
Loading