Add check on off-diag quadratics#80
Open
LucaMantani wants to merge 3 commits into
Open
Conversation
Collaborator
|
Yes, I think it'd be good to write explicit zeros. This way we keep a consistent structure which makes it easier to design tests without cornercases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two checks on off-diag quadratics:
Op1*Op2andOp2*Op1. This test passes ✅Op1andOp2are present in the dictionary, then alsoOp1*Op2orOp2*Op1is present. This test does not pass ❌Some tables (the Higgs ones) I knew would not pass because they are currently missing some contributions, now implemented in #77 . However, other tables are missing contributions. It might be that some of them are missing them because they are zero, in which case it is not strictly a problem (smefit would fill in zeros), but we could discuss whether we want to have a policy where we write the zeros explicitly to not create ambiguity?