Make the report function cross-platform.#212
Draft
arossia94 wants to merge 2 commits into
Draft
Conversation
Changes required to make the report function work on Windows too. The should still run as usual on Linux/Mac but requires verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the fitting functionalities of SMEFiT ran fine on any platform, Windows included, the report function didn't.
This PR implements the small changes required to make the report function work on any platform.
The code should still run as usual on Linux/Mac, but requires verification.
This was used for my outreach talk at PyData Venice.