Add closure-truth vertical lines to posterior plots#211
Conversation
|
Thanks for opening this PR @WopkeTelman ! I have a few questions. |
| """Compute closure-truth Wilson coefficients from a coefficient config.""" | ||
| fit_truth = {coeff_name: 0.0 for coeff_name in coeff_names} | ||
| if not coeff_cfg: | ||
| return fit_truth |
There was a problem hiding this comment.
I would add a clear warning to the user here that the default values 0 is being used
There was a problem hiding this comment.
Also what does coeff_cfg stand for? It is not immediately obvious to me
| coeff_set = set(coefficients.name) | ||
| for coeff_name in coeff_names: | ||
| if coeff_name not in coeff_set: | ||
| continue |
There was a problem hiding this comment.
Again, maybe need a relevant warning here
| return fit_truth | ||
|
|
||
| def _load_closure_truth_points_from_runcards( | ||
| self, closure_truth_runcards, coeff_names |
There was a problem hiding this comment.
Are you loading the truth from the report runcard or from the projection runcard? Or both?
In any case, the possible options need to be better documented, both in the source code and in the example runcards
|
Also did you implement this feature for the 2D corner plots already? I did not see an example runcard for it on our private repo |
2 participants
plot_posteriorsreport.pyto the plotting layerRelated to #209