Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use template to create similar structures #4

Conversation

Yaraslaut
Copy link
Member

@Yaraslaut Yaraslaut commented Oct 7, 2024

Closes #1 and closes #3

This PR refactors creation of structures inside XRechnungMapping.hpp, to use templates and reduce amount of highly repeating code

@Yaraslaut Yaraslaut force-pushed the improvement/mapping_entry_template branch from f3b16c6 to a382494 Compare October 7, 2024 18:27
@Yaraslaut Yaraslaut marked this pull request as ready for review October 7, 2024 18:29
@Yaraslaut Yaraslaut marked this pull request as draft October 7, 2024 18:30
@Yaraslaut Yaraslaut force-pushed the improvement/mapping_entry_template branch from a382494 to 19f1e8c Compare October 8, 2024 05:15
@Yaraslaut Yaraslaut marked this pull request as ready for review October 8, 2024 05:16
@christianparpart christianparpart force-pushed the improvement/mapping_entry_template branch from 19f1e8c to 955f18d Compare October 8, 2024 06:14
@christianparpart
Copy link
Member

@Yaraslaut FYI: I've been rebasing this branch on top of latest master to include the just merged other PR's.

@christianparpart christianparpart merged commit 5146a5c into LASTRADA-Software:master Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BuyerContactEMail::id Less code repetition in XRechnungMapping.hpp for some structure declarations
2 participants