Skip to content

Conversation

@JiangJiaWei1103
Copy link

@JiangJiaWei1103 JiangJiaWei1103 commented Dec 20, 2025

Why are these changes needed?

To focus on the log collector component only, we streamline the collector image building process and provide a step-by-step guide to set up the collector in a Ray cluster.

Related issue number

Closes ray-project#4276.

Related PR

We need to make sure changes in #1 are applied first. Further changes start from 586f6ac.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Comment on lines +127 to +147
### Deploy a Ray Cluster for Checks

### Testing

To run tests:
Finally, you can check if the log collector works as expected by deploying a Ray cluster with the collector enabled and
interacting with the minio UI.

```bash
make test
# Apply the Ray cluster manifest.
kubectl apply -f config/raycluster.yaml
```

### Linting

To run lint checks:
Since the session latest logs will be processed upon the Ray cluster is deleted, you can manully delete the Ray clsuter
to trigger log file uploading:

```bash
make alllint
# Trigger the session latest log processing upon deletion.
kubectl delete -f config/raycluster.yaml
```

## Deployment
You're supposed to see the uploaded logs in the minio UI as below:

History Server can be deployed in Kubernetes using the manifests in the `config/samples/` directory.
Examples are provided for different storage backends including MinIO and Aliyun OSS.
![write_logs](https://github.com/KunWuLuan/kuberay/blob/0a70a0e354db13d005e90de9817e8a87308e4810/historyserver/assets/write_logs.png)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, we only check logs are successfully uploaded to the minio upon the Ray cluster is deleted. We'll add more cases here and cover them in e2e tests.

Signed-off-by: JiangJiaWei1103 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant