forked from ray-project/kuberay
-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] Add history server log collector setup guide #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JiangJiaWei1103
wants to merge
30
commits into
KunWuLuan:historyserver-beta-collector
Choose a base branch
from
JiangJiaWei1103:add-log-collector-setup-guide
base: historyserver-beta-collector
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Add history server log collector setup guide #2
JiangJiaWei1103
wants to merge
30
commits into
KunWuLuan:historyserver-beta-collector
from
JiangJiaWei1103:add-log-collector-setup-guide
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
JiangJiaWei1103
commented
Dec 21, 2025
Comment on lines
+127
to
+147
| ### Deploy a Ray Cluster for Checks | ||
|
|
||
| ### Testing | ||
|
|
||
| To run tests: | ||
| Finally, you can check if the log collector works as expected by deploying a Ray cluster with the collector enabled and | ||
| interacting with the minio UI. | ||
|
|
||
| ```bash | ||
| make test | ||
| # Apply the Ray cluster manifest. | ||
| kubectl apply -f config/raycluster.yaml | ||
| ``` | ||
|
|
||
| ### Linting | ||
|
|
||
| To run lint checks: | ||
| Since the session latest logs will be processed upon the Ray cluster is deleted, you can manully delete the Ray clsuter | ||
| to trigger log file uploading: | ||
|
|
||
| ```bash | ||
| make alllint | ||
| # Trigger the session latest log processing upon deletion. | ||
| kubectl delete -f config/raycluster.yaml | ||
| ``` | ||
|
|
||
| ## Deployment | ||
| You're supposed to see the uploaded logs in the minio UI as below: | ||
|
|
||
| History Server can be deployed in Kubernetes using the manifests in the `config/samples/` directory. | ||
| Examples are provided for different storage backends including MinIO and Aliyun OSS. | ||
|  |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, we only check logs are successfully uploaded to the minio upon the Ray cluster is deleted. We'll add more cases here and cover them in e2e tests.
Signed-off-by: JiangJiaWei1103 <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To focus on the log collector component only, we streamline the collector image building process and provide a step-by-step guide to set up the collector in a Ray cluster.
Related issue number
Closes ray-project#4276.
Related PR
We need to make sure changes in #1 are applied first. Further changes start from 586f6ac.
Checks