Remove assumptions about the concrete type of builders #958
+12
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes assumptions about the concrete type of builders as they are not always true due to
CustomBuilderObject
Example Script
Any use of event.createCustom for items or block entities, like so:
Other details
Original report and example script from the discord: support-1.21 - crash when trying to create a world due to event.createCustom
Other usages found and reviewed with regex
Builder\) [a-zA-Z$]+