Added non-conflicting methods delegating tests to Holder.is
#957
+54
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Holder<T>
is often used in the game coding, however it contains 5 overrides ofis
method each with different parameter type, which will cause Rhino to just not work for most of the time, since many of these types are overlapping in type wrapping (e.g.TagKey
,ResourceKey
andResourceLocation
.This PR leaves only
is(ResourceLocation)
to test if the resource location is the one holder holds, and renamedis(Predicate<ResourceKey>)
totest(Predicate<ResourceKey>)
, and addedisTag(ResourceLocation)
to test if the holder has a key represented by the resource location.Example Script
Other details
is
overrides are all tagged@HideFromJS
isTag
is needed instead of remapping names due to Rhino is unable to wrap the tag from typeTagKey<T>
.